blib/lib/Module/Advisor.pm

filter: Statementstmt 30.7% 28 / 91 Branchbran 7.1% 2 / 28 Conditioncond n/a MC/DCmcdc n/a Subroutinesub 33.3% 6 / 18 Podpod 0.0% 0 / 10 totaltotal 24.4% 36 / 147 CC 14 SCAR 23.3
CC
14
Cov
25%
_check_issue
20.0
check_xs_installed
20.0
_check_optional
20.0
CRAP 10.3
↑ Summary
1 package Module::Advisor;
2 1 ▶use strict;
Subroutine BEGIN: called CC=1 SCAR=0.0
3 1 ▶use warnings;
Subroutine BEGIN: called CC=1 SCAR=0.0
4 1 ▶use 5.008008;
Subroutine BEGIN: called CC=1 SCAR=0.0
5 1 our $VERSION = '0.17';
6 1 ▶use Module::Metadata;
Subroutine BEGIN: called CC=1 SCAR=0.0
7 1 ▶use CPAN::Meta::Requirements;
Subroutine BEGIN: called CC=1 SCAR=0.0
8 1 ▶use Carp;
Subroutine BEGIN: called CC=1 SCAR=0.0
9  
10 1 our @SECURITY = (
11 ['Digest' => '< 1.17', 'have a security issue. which could lead to the injection of arbitrary Perl code'],
12 ['Encode' => '< 2.44', 'heap overflow'],
13 ['Encode' => '< 2.49', 'memory leaks'],
14 );
15  
16 1 our @PERFORMANCE = (
17 ['UNIVERSAL::require', '< 0.11', 'is 400% faster'],
18 );
19  
20 1 our @BUG = (
21 ['Plack' => '< 0.9982', 'sanity check to remove newlines from headers'],
22 ['Time::Piece' => '< 1.16', 'have timezone related issue'],
23 ['DBD::SQLite' => '< 1.20', 'a lot of bugs.'],
24 ['Mouse' => '>= 1.07, < 1.12', 'Memory leaks in trigger'],
25 ['Text::Xslate' => '< 1.0011', '&apos; bug.'],
26 ['Text::Xslate' => '< 1.5021', 'segv in "render" recursion call'],
27 ['Text::Xslate' => '< 1.6001', 'possibly memory leaks on VM stack frames. see https://github.com/xslate/p5-Text-Xslate/issues/71'],
28 ['Text::Xslate' => '< 2.0005', 'Nested WRAPPER broken https://github.com/xslate/p5-Text-Xslate/issues/79'],
29 ['Furl' => '< 0.39', 'unexpected eof in reading chunked body. It makes busy loop.'],
30 ['AnyEvent::MPRPC' => '< 0.15', 'switch to Data::MessagePack::Stream'],
31 ['Data::MessagePack' => '< 0.46', 'fixed unpacking issue on big-endian system.'],
32 ['Data::MessagePack' => '< 0.39', 'packing float numbers fails on some cases'],
33 ['FCGI::Client' => '< 0.06', 'fixed large packet issue'],
34 ['Starlet' => '< 0.12', 'fix infinite loop when connection is closed while receiving response content'],
35 ['Starman' => '< 0.2014', '$res->[1] is broken after output (This is actualized with Plack::Middleware::AccessLog::Timed) https://github.com/miyagawa/Starman/pull/31'],
36 ['Starman' => '< 0.1006', 'Fixed 100% CPU loop when an unexpected EOF happens'],
37 ['Twiggy' => '< 0.1000', 'busy loop'],
38 ['Teng', '< 0.14', 'fixed deflate bug.'],
39 ['DBIx::Skinny', '< 0.0742', 'txn_scope bug fixed'],
40 ['DBIx::TransactionManager', '< 1.11', 'not execute begin_work at AutoCommit=0.'],
41 ['HTTP::MobileAgent' => '< 0.36', 'new x-up-devcap-multimedia(StandAloneGPS) support'],
42 ['HTTP::MobileAgent' => '< 0.35', 'Updated $HTMLVerMap and $GPSModelsRe in DoCoMo.pm'],
43 ['Encode::JP::Mobile' => '< 0.25', 'resolved FULLWIDTH TILDE issue, etc.'],
44 ['Template' => '< 2.15', 'uri filter does not works properly https://rt.cpan.org/Public/Bug/Display.html?id=19593'],
45 ['HTML::FillInForm::Lite' => '< 1.11', 'HTML5 style tags support'],
46 ['Proc::Daemon' => '< 0.12', 'Init() did not close all filehandles reliably in some cases.'],
47 ['ExclusiveLock::Guard' => '< 0.04', 'change of the file stat timing (measures under high load)'],
48 ['autobox', '< 2.78', 'segv in END block https://rt.cpan.org/Ticket/Display.html?id=80400'],
49  
50 # Broken in specific versions
51 ['Amon2::DBI' => '== 0.31', 'transaction management bug'],
52 ['Math::Random::MT' => '== 1.15', 'rand() took no notice of argument RT #78200'],
53 ['Module::Install' => '== 1.04', 'Broken, http://weblog.bulknews.net/post/33907905561/do-not-ship-modules-with-module-install-1-04'],
54 ['Mouse' => '== 1.04', 'Broken, http://d.hatena.ne.jp/gfx/20130208/1360283357'],
55 ['Plack::Middleware::AxsLog' => '== 0.20', 'Missing \n'],
56 );
57  
58 1 our @XS = (
59 ['JSON' => 'JSON::XS'],
60 # ['PPI' => 'PPI::XS'], # I think PPI::XS is outdated.
61 ['Plack' => 'HTTP::Parser::XS'],
62 );
63 1 ▶if ($^O eq 'linux') {
Branch: 1 branch
BranchTrueFalseTotal
if ($^O eq "linux") 1 0 1
64 1 push @XS, ['Filesys::Notify::Simple', 'Linux::Inotify2'];
65 }
66  
67 1 our @FEATURE = (
68 ['Amon2' => '< 3.29', 'JSON hijacking detection.'],
69 ['Log::Minimal' => '< 0.10', 'LM_COLOR'],
70 ['Log::Minimal' => '< 0.08', 'colourful logging'],
71 ['Log::Minimal' => '< 0.03', 'ddf'],
72 ['Proclet' => '< 0.12', 'Proclet::Declare'],
73 ['DBI', '< 1.614' => 'AutoInactiveDestroy'],
74 ['Module::Install::XSUtil', '< 0.44' => 'PUREPERL_ONLY=1'],
75 );
76  
77 1 our @OPTIONAL_MODULES = (
78 ['LWP', 'LWP::Protocol::https', 'Need to support https'],
79 );
80  
81 # ref. Module::Version
82 0 ▶sub get_version {
Subroutine get_version: not called CC=3 SCAR=24.8
Pod undocumented
83 0 ▶ my $module = shift or croak 'Must get a module name';
Branch: 1 branch
BranchTrueFalseTotal
my $module = shift() or croak("Must get a module name") 0 0 0
84 0 my $metadata = Module::Metadata->new_from_module($module);
85 0 ▶ $metadata ? $metadata->version : undef;
Branch: 1 branch
BranchTrueFalseTotal
$metadata ? : 0 0 0
86 }
87  
88 0 ▶sub debugf {
Subroutine debugf: not called CC=2 SCAR=17.9
Pod undocumented
89 0 my $self = shift;
90 0 ▶ print "# @_\n" if $self->{verbose};
Branch: 1 branch
BranchTrueFalseTotal
if $self->{"verbose"} 0 0 0
91 }
92  
93 0 ▶sub new {
Subroutine new: not called CC=2 SCAR=17.9
Pod undocumented
94 0 my $class = shift;
95 0 ▶ my %args = @_==1 ? %{$_[0]} : @_;
Branch: 1 branch
BranchTrueFalseTotal
@_ == 1 ? : 0 0 0
96 0 bless {%args}, $class;
97 }
98  
99 0 ▶sub check {
Subroutine check: not called CC=1 SCAR=6.9
Pod undocumented
100 0 my ($self) = @_;
101 0 my $failed = 0;
102 0 $failed += $self->check_security();
103 0 $failed += $self->check_performance();
104 0 $failed += $self->check_bugs();
105 0 $failed += $self->check_xs_installed();
106 0 $failed += $self->check_feature();
107 0 return $failed;
108 }
109  
110 0 ▶sub matches_version {
Subroutine matches_version: not called CC=1 SCAR=6.9
Pod undocumented
111 0 my($self, $module, $spec, $version) = @_;
112  
113 0 my $requirements = CPAN::Meta::Requirements->new;
114 0 $requirements->add_string_requirement($module, $spec);
115  
116 0 $requirements->accepts_module($module, $version);
117 }
118  
119 0 ▶sub _check_issue {
Subroutine _check_issue: not called CC=4 SCAR=30.0
120 0 my ($self, $patterns, $type_name) = @_;
121 0 my $failed = 0;
122 0 for my $row (@$patterns) {
123 0 my $ver = get_version($row->[0]);
124 0 ▶ if (defined $ver) {
Branch: 1 branch
BranchTrueFalseTotal
if (defined $ver) { } 0 0 0
125 0 $self->debugf("$row->[0] $ver");
126 0 ▶ if ($self->matches_version($row->[0], $row->[1], $ver)) {
Branch: 1 branch
BranchTrueFalseTotal
if ($self->matches_version($row->[0], $row->[1], $ver)) 0 0 0
127 0 printf "[$type_name] %s %s %s: %s\n", $row->[0], $ver, $row->[1], $row->[2];
128 0 $failed++;
129 }
130 } else {
131 0 $self->debugf("$row->[0] is not found");
132 }
133 }
134 0 return $failed;
135 }
136  
137 0 ▶sub check_security {
Subroutine check_security: not called CC=1 SCAR=6.9
Pod undocumented
138 0 my $self = shift;
139 0 $self->_check_issue(\@SECURITY, 'SECURITY');
140 }
141  
142 0 ▶sub check_performance {
Subroutine check_performance: not called CC=1 SCAR=6.9
Pod undocumented
143 0 my $self = shift;
144 0 $self->_check_issue(\@PERFORMANCE, 'PERFORMANCE');
145 }
146  
147 0 ▶sub check_bugs {
Subroutine check_bugs: not called CC=1 SCAR=6.9
Pod undocumented
148 0 my $self = shift;
149 0 $self->_check_issue(\@BUG, 'BUG');
150 }
151  
152 0 ▶sub check_xs_installed {
Subroutine check_xs_installed: not called CC=4 SCAR=30.0
Pod undocumented
153 0 my ($self) = @_;
154 0 my $failed = 0;
155 0 for my $row (@XS) {
156 0 my $pmver = get_version($row->[0]);
157 0 ▶ if (defined $pmver) {
Branch: 1 branch
BranchTrueFalseTotal
if (defined $pmver) { } 0 0 0
158 0 my $xsver = get_version($row->[1]);
159 0 ▶ if (defined $xsver) {
Branch: 1 branch
BranchTrueFalseTotal
if (defined $xsver) { } 0 0 0
160 0 $self->debugf("$row->[1] is also installed");
161 } else {
162 0 printf "[XS] %s is need to install for better performance for %s\n", $row->[1], $row->[0];
163 }
164 } else {
165 0 $self->debugf("$row->[0] is not installed");
166 }
167 }
168 }
169  
170 0 ▶sub _check_optional {
Subroutine _check_optional: not called CC=4 SCAR=30.0
171 0 my ($self, $rules, $type_name) = @_;
172 0 my $failed = 0;
173 0 for my $row (@$rules) {
174 0 my $pmver = get_version($row->[0]);
175 0 ▶ if (defined $pmver) {
Branch: 1 branch
BranchTrueFalseTotal
if (defined $pmver) { } 0 0 0
176 0 my $xsver = get_version($row->[1]);
177 0 ▶ if (defined $xsver) {
Branch: 1 branch
BranchTrueFalseTotal
if (defined $xsver) { } 0 0 0
178 0 $self->debugf("$row->[1] is also installed");
179 } else {
180 0 printf "[$type_name] %s => %s: %s\n", $row->[1], $row->[0], $row->[2];
181 }
182 } else {
183 0 $self->debugf("$row->[0] is not installed");
184 }
185 }
186 }
187  
188 0 ▶sub check_feature {
Subroutine check_feature: not called CC=1 SCAR=6.9
Pod undocumented
189 0 my $self = shift;
190 0 $self->_check_optional(\@OPTIONAL_MODULES, 'OPTIONAL_MODULES');
191 }
192  
193 1 ▶if (not defined caller(0)) {
Branch: 1 branch
BranchTrueFalseTotal
unless (defined caller 0) 0 1 1
194 0 my $checker = __PACKAGE__->new();
195 0 ▶ $checker->{verbose}++ if $ENV{DEBUG};
Branch: 1 branch
BranchTrueFalseTotal
if $ENV{"DEBUG"} 0 0 0
196 0 ▶ $checker->check() or print "OK\n";
Branch: 1 branch
BranchTrueFalseTotal
$checker->check or print "OK\n" 0 0 0
197 }
198  
199 1 1;
↑ Summary